-
Notifications
You must be signed in to change notification settings - Fork 533
DOC: Move users docs from nipype to nipype_tutorial #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -16,7 +16,8 @@ image from Docker hub:: | |||
docker pull nipype/nipype | |||
|
|||
You may also build custom docker containers with specific versions of software | |||
using Neurodocker_ (see the :doc:`neurodocker`). | |||
using Neurodocker_ (see the `Neurodocker tutorial | |||
<https://miykael.github.io/nipype_tutorial/notebooks/introduction_neurodocker.html>`_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to nipype.github.io/tutorial
? Not sure if we already had discussion there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're talking about the whole nipype_tutorial
? Fine with me, but we haven't discussed it yet, or decided what to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.
This seems fine to me. Are there any outstanding issues? Can you merge master to get the latest version of testing in? One quick note: |
Actually, would you mind pushing a build of the docs to your |
Codecov Report
@@ Coverage Diff @@
## master #2726 +/- ##
=========================================
- Coverage 67.44% 64.24% -3.2%
=========================================
Files 340 338 -2
Lines 43164 43102 -62
Branches 5351 5348 -3
=========================================
- Hits 29110 27692 -1418
- Misses 13355 14333 +978
- Partials 699 1077 +378
Continue to review full report at Codecov.
|
I merged with master and renamed 3 outstanding issuesCommand line interfaceIf Saving Workflows and Nodes to a file (experimental)As mentioned above, this content is only in a WIP notebook and therefore not visible on the tutorial homepage. The problem is that Resource Scheduling and Profiling with NipypeThe resource profiler content is only as a WIP in the tutorial and doesn't work in the notebook, yet. I think this is addressed in #2571, but the proposed solution doesn't work in the container. MishapAlso, I unfortunately first updated the |
I reverted Yes, I would leave the WIP notebooks as WIP at least until 2.0. Perhaps someone will fix the issues? I would go ahead and open issues for those notebooks here, as the fixes probably need to be done here. Happy to be overruled by @satra on any and all points. |
@miykael Are you happy with this at least for this release? We can open issues for any remaining things to fix in 1.1.5. |
@effigies, yes. In my opinion it's good to go. Will keep track about any issues and open missing issues for the WIP on the tutrial homepage. |
Summary
PR miykael/nipype_tutorial#77 and miykael/nipype_tutorial#128 moved the content under User Guide already to the
nipype_tutorial
, but we haven't removed this content fromnipype
, yet. This PR takes care of that.Deviation between the content
There are three sections that have been copied to the tutorial but either leads to errors or are still WIP:
Saving Workflows and Nodes to a file (experimental)
Running
wf.export('special_workflow.py')
in the notebook will lead to aTypeError: a bytes-like object is required, not 'str'
. As the content of this section is still "experimental", I think it's ok if we leave it as WIP.Running Nipype Interfaces from the command line (nipype_cmd)
The content between
nipype
andnipype_tutorial
is identical. But currently, we're not running any tests, as the commandnipype_cmd
doesn't work inside the docker image. I haven't usednipype_cmd
yet myself, but it seemsnipype
needs to be installed via apt install python-nipype for this to work?Resource Scheduling and Profiling with Nipype
The content between
nipype
andnipype_tutorial
is identical, but running the profiler within the docker image leads to the errorAttributeError: 'list' object has no attribute 'startTime'
. This is caused by the fact that the profiling information is not handed over as an object but as an object inside a list.To consider
Removing the "User Docs" from
nipype
leads to new issues that need to be considered:install.rst
wasn't removed fromdoc/users
as it is also needed innipype
's Quickstart section.doc/users
contains a folderexamples
that contains the workflow examples under Interfaces, Workflows and Examples. Once those workflows are included underniflows
, this folder can be removed.API
andDeveloper Guide
into two columns (see below). But the current setup has titles, as well as links to the corresponding sections. Should we take care of this?