Skip to content

[FIX] Update pytest req'd version to 3.6 #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018
Merged

[FIX] Update pytest req'd version to 3.6 #2827

merged 1 commit into from
Dec 14, 2018

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Dec 14, 2018

Fixes #2826.

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #2827 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2827      +/-   ##
==========================================
+ Coverage   67.45%   67.47%   +0.02%     
==========================================
  Files         341      341              
  Lines       43343    43343              
  Branches     5375     5375              
==========================================
+ Hits        29235    29247      +12     
+ Misses      13409    13399      -10     
+ Partials      699      697       -2
Flag Coverage Δ
#smoketests 50.55% <100%> (ø) ⬆️
#unittests 64.89% <100%> (+0.04%) ⬆️
Impacted Files Coverage Δ
nipype/info.py 94.11% <100%> (ø) ⬆️
nipype/interfaces/dcm2nii.py 48.13% <0%> (+0.93%) ⬆️
nipype/testing/utils.py 91.37% <0%> (+1.72%) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 66% <0%> (+4.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d3dfa...a4dfe7e. Read the comment docs.

@effigies
Copy link
Member

That does seem to fix it... Since we don't depend on pytest-xdist>=1.25, we don't, strictly speaking, need pytest>=3.6, so the question is whether to update the requirement or just update the Travis environment to satisfy the dependency, either by upgrading pytest or downgrading pytest-xdist. I'm not sure it's worth caring about, but pytest 3.6 is only 6 months old. As a matter of fussiness, it's nice not to force people to upgrade a bunch of things in their environment to upgrade nipype unless we really need to.

@effigies effigies added this to the 1.1.7 milestone Dec 14, 2018
@oesteban
Copy link
Contributor Author

They are adding a lot of very cool fixtures that can help make the tests faster to write. I particularly don't mind updating this one.

@effigies
Copy link
Member

Okay. Fine with me.

@effigies effigies merged commit 8603729 into master Dec 14, 2018
yarikoptic added a commit to yarikoptic/nipype that referenced this pull request Jan 11, 2019
1.1.7 (December 17, 2018)

* FIX: Copy node list before generating a flat graph (nipy#2828)
* FIX: Update pytest req'd version to 3.6 (nipy#2827)
* FIX: Set ResourceMonitor.fname to an absolute path (nipy#2824)
* FIX: Order of SPM.NewSegment channel_info boolean tuple is (Field, Corrected) (nipy#2817)
* FIX: Indices were swapped for memory and cpu profile data (nipy#2816)
* FIX: ``status_callback`` not called with ``stop_on_first_crash`` (nipy#2810)
* FIX: Change undefined ScriptError on LFS plugin to IOError (nipy#2803)
* ENH: Add NaN failure mode to CompCor interfaces (nipy#2819)
* ENH: Enable cnr_maps and residuals outputs for FSL eddy (nipy#2750)
* ENH: Improve ``str2bool`` + doctests (nipy#2807)
* TST: Improve py.test configuration of doctests (nipy#2802)
* DOC: Update DOI badge to point to all versions (nipy#2804)
* MAINT: Offload interfaces with help formatting (nipy#2797)
* MAINT: Reduce minimal code redundancy in filemanip.get_dependencies (nipy#2782)
* MAINT: Delayed imports to reduce import time (nipy#2809)
...
@effigies effigies deleted the oesteban-patch-2 branch January 14, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.4 tests failing on Travis
3 participants