Skip to content

[FIX] Update FNIRT outputs for warped_file log_file to include cwd #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

BenjaminMey
Copy link
Contributor

Summary

Issue regarding the fix: #2899

List of changes proposed in this PR (pull-request)

  • When warped_file or log_file input is set, will append the new name to the current working directory.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov-io
Copy link

Codecov Report

Merging #2900 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2900      +/-   ##
==========================================
- Coverage   67.56%   67.54%   -0.03%     
==========================================
  Files         343      343              
  Lines       43601    43601              
  Branches     5427     5427              
==========================================
- Hits        29460    29451       -9     
- Misses      13436    13444       +8     
- Partials      705      706       +1
Flag Coverage Δ
#smoketests 50.47% <0%> (ø) ⬆️
#unittests 64.96% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/preprocess.py 82.6% <100%> (ø) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 61.5% <0%> (-4.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232ac23...7219ca3. Read the comment docs.

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mgxd mgxd added this to the 1.2.0 milestone Mar 27, 2019
@mgxd mgxd merged commit fcbe28e into nipy:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FNIRT warped_file, log_file output name as inval
3 participants