[REF] removed all uses of numpy_mmap

[iugastefan922]

Summary

Removed all use cases of numpy_mmap as it will always be true.

Acknowledgment

I acknowledge that this contribution will be available under the Apache 2 license.

[codecov]

Codecov Report

Merging #3121 into master will decrease coverage by 2.82%.
The diff coverage is 39.13%.

@@            Coverage Diff            @@
##           master   #3121      +/-   ##
=========================================
- Coverage   67.83%     65%   -2.83%     
=========================================
  Files         295     295              
  Lines       39302   39290      -12     
  Branches     5178    5178              
=========================================
- Hits        26661   25541    -1120     
- Misses      11935   12699     +764     
- Partials      706    1050     +344

Flag	Coverage Δ
#smoketests	?
#unittests	65% <39.13%> (-0.06%)	⬇️

Impacted Files	Coverage Δ
nipype/utils/__init__.py	100% <ø> (ø)	⬆️
nipype/utils/config.py	58.33% <ø> (-6.87%)	⬇️
nipype/algorithms/icc.py	57.53% <ø> (-0.58%)	⬇️
nipype/interfaces/dipy/preprocess.py	26.55% <0%> (-0.42%)	⬇️
nipype/interfaces/mrtrix/convert.py	17.18% <0%> (+0.17%)	⬆️
nipype/interfaces/dcmstack.py	35.1% <0%> (-0.27%)	⬇️
nipype/interfaces/fsl/epi.py	62.08% <0%> (-0.08%)	⬇️
nipype/algorithms/rapidart.py	34.42% <0%> (-29.78%)	⬇️
nipype/algorithms/misc.py	45.24% <50%> (-0.19%)	⬇️
nipype/algorithms/modelgen.py	59.61% <66.66%> (-8.07%)	⬇️
... and 42 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3279c...e4b18c6. Read the comment docs.

[effigies]

This LGTM. One potential problem is removing the NUMPY_MMAP constant altogether, if any downstream projects use it. Perhaps we should leave it (anybody have strong opinions?) for now, though we can simply make it True.

If we are going to leave it, we should have a plan for removing it, including how to notify developers that it's going away. Raising a DeprecationWarning would require some tricky hacks, and might not be worth it. Possibly just a warning in the release notes?

WDYT?

[effigies]

This leaves the numpy import unused.

[satra]

One potential problem is removing the NUMPY_MMAP constant altogether, if any downstream projects use it.

i think we should just remove it. while not explicit, this was not intended to be an external api. hopefully developers will catch this via release candidates if they were re-using this constant.

[effigies]

Works for me.