Skip to content

Backport: gh-3143 to 1.3.x branch #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 6, 2020

Backports #3143 to 1.3.x.

  • fix: mapnode to generate result file when crashes in single node mode
  • enh: simplify test further
  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

* fix: mapnode to generate result file when crashes in single node mode
* enh: simplify test further
@effigies
Copy link
Member Author

effigies commented Jan 6, 2020

Confirming that this branch also fixes #3088.

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #3144 into maint/1.3.x will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.3.x    #3144      +/-   ##
===============================================
- Coverage         68.2%   68.14%   -0.06%     
===============================================
  Files              297      297              
  Lines            39815    39822       +7     
  Branches          5218     5218              
===============================================
- Hits             27154    27137      -17     
- Misses           11951    11974      +23     
- Partials           710      711       +1
Flag Coverage Δ
#smoketests 51.76% <50%> (ø) ⬆️
#unittests 65.37% <100%> (-0.11%) ⬇️
Impacted Files Coverage Δ
nipype/info.py 90.14% <ø> (ø) ⬆️
nipype/pipeline/engine/nodes.py 83.6% <100%> (+0.18%) ⬆️
nipype/interfaces/dcm2nii.py 59.06% <0%> (-6.05%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 63% <0%> (-5%) ⬇️
nipype/pipeline/plugins/tools.py 79.48% <0%> (-1.29%) ⬇️
nipype/pipeline/engine/utils.py 80.65% <0%> (-0.12%) ⬇️
nipype/__init__.py 61.9% <0%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990f3fa...3c9a239. Read the comment docs.

@effigies effigies merged commit bf70ed1 into nipy:maint/1.3.x Jan 6, 2020
@effigies effigies deleted the bp/1.3.x/gh-3143 branch January 6, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants