Skip to content

Misc internal optimizations #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Conversation

asomers
Copy link
Member

@asomers asomers commented Nov 19, 2022

  • Make ipv4addr_to_libc const
  • Use mem::transmute in ipv4addr_to_libc and ipv6addr_to_libc

Fixes #1687
Fixes #1688

* Make ipv4addr_to_libc const
* Use mem::transmute in ipv4addr_to_libc and ipv6addr_to_libc

Fixes nix-rust#1687
Fixes nix-rust#1688
@asomers asomers requested a review from rtzoeller November 19, 2022 22:08
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note to the changelog about making the function const.

@asomers
Copy link
Member Author

asomers commented Nov 19, 2022

No need for CHANGELOG, because it isn't a public function.

bors r=rtzoeller

@bors bors bot merged commit 2ad2f48 into nix-rust:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSRV 1.56.0 TODO MSRV 1.50.0 TODO
2 participants