Remove 'static mut' usage in features::os::kernel_version. #2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(see bytecodealliance/rustix#645 about CI failures) |
(re-commit for CI retry after rustix 0.37.18 release)
zachs18
force-pushed
the
atomic_kernel_version
branch
from
0169fff to
2f60820
Compare
asomers
approved these changes
May 20, 2023
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2028
Note that this is (AFAICT) the first use of
Atomic*types innix(other than tests). However, this shouldn't be a portability issue, sincenixis not#![no_std], and (IIUC)stdrequires at least loads and stores of pointer-sized atomics (i.e.AtomicUsize), which is all this PR uses.