Skip to content

ci: check newly-added CHANGELOGs in CI #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 13, 2024

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Apr 13, 2024

What does this PR do

This PR adds a new composite Github Action check_new_changelog(.github/actions/check_new_changelog/action.yml) and applies it in our ci.yml, for those newly-added changelog files under the changelog directory, it will check:

  1. the CHANGELOG kind belongs to [added, changed, fixed, removed]
  2. the PR number matches the real one
  3. the file extension is md

Closes #2357

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

# Only checek the files under the `changelog` directory
files: changelog/**

- name: List added CHANGELOGs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be something like Check them

@SteveLauC SteveLauC merged commit 2bc9717 into nix-rust:master Apr 13, 2024
@SteveLauC SteveLauC deleted the ci/check_pr_id_changelog branch April 13, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check CHANGELOG PR ID in CI
1 participant