Revert "return 0 (false) from Client.connect(hostname,port) when DNS-lookup didn't succeed"

ntruchsess · ntruchsess · commit de711848bb79 · 2014-01-17T07:33:56.000+01:00
This reverts commit 6086a36.
diff --git a/UIPClient.cpp b/UIPClient.cpp
@@ -78,16 +78,18 @@ int
 UIPClient::connect(const char *host, uint16_t port)
 {
   // Look up the host first
+  int ret = 0;
 #if UIP_UDP
   DNSClient dns;
   IPAddress remote_addr;
 
   dns.begin(UIPEthernet.dnsServerIP());
-  if (dns.getHostByName(host, remote_addr) == 1) {
+  ret = dns.getHostByName(host, remote_addr);
+  if (ret == 1) {
     return connect(remote_addr, port);
   }
 #endif
-  return 0;
+  return ret;
 }
 
 void

Original file line number	Diff line number	Diff line change
`@@ -78,16 +78,18 @@ int`
`78`	`78`	`UIPClient::connect(const char *host, uint16_t port)`
`79`	`79`	`{`
`80`	`80`	`// Look up the host first`
	`81`	`+ int ret = 0;`
`81`	`82`	`#if UIP_UDP`
`82`	`83`	`DNSClient dns;`
`83`	`84`	`IPAddress remote_addr;`
`84`	`85`
`85`	`86`	`dns.begin(UIPEthernet.dnsServerIP());`
`86`		`- if (dns.getHostByName(host, remote_addr) == 1) {`
	`87`	`+ ret = dns.getHostByName(host, remote_addr);`
	`88`	`+ if (ret == 1) {`
`87`	`89`	`return connect(remote_addr, port);`
`88`	`90`	`}`
`89`	`91`	`#endif`
`90`		`- return 0;`
	`92`	`+ return ret;`
`91`	`93`	`}`
`92`	`94`
`93`	`95`	`void`