Skip to content

Remove Twitter links in English version #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Dec 20, 2024

Conversation

star1327p
Copy link
Contributor

Brief description of what is fixed or changed

  1. Replaced Twitter with X, including the links https://x.com/numpy_team .

  2. Updated the Youtube channel to a shorter URL https://www.youtube.com/@NumPy_team .

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit a074f0c
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/6764ca61fa246800083302a0
😎 Deploy Preview https://deploy-preview-808--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seberg
Copy link
Member

seberg commented Dec 19, 2024

Thanks for looking into this. xref numpy/numpy#28036 (twitter is in the NumPy readme).

We removed the main X/twitter link in #767 (we never used it that much), so we may even just want to remove it. @InessaPawson what do you prefer?

@InessaPawson
Copy link
Member

@seberg +1 on removing the mention and the link to the NumPy X account.

@InessaPawson
Copy link
Member

@star1327p Thank you for working on this PR! Please note that the translations on numpy.org are done by our translations team via Crowdin. Please remove all pending changes for any language versions other than English.

@star1327p
Copy link
Contributor Author

@seberg @InessaPawson Thank you both for reviewing! I have removed the Twitter link in the English version, and reverted my changes in the other languages.

@star1327p star1327p changed the title Update twitter and youtube links Remove Twitter links in English version Dec 20, 2024
@InessaPawson InessaPawson merged commit 55f6df7 into numpy:main Dec 20, 2024
4 checks passed
@InessaPawson
Copy link
Member

Thank you, @star1327p!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants