Skip to content

TYP: Fix type annotations for np.ma.nomask and np.ma.MaskType #28831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Apr 26, 2025

Not sure that the current type hints are correct for these, as np.ma.nomask returns a NumPy boolean, not a stdlib one

@MarcoGorelli MarcoGorelli force-pushed the fix-ma-nomask-masktype branch 2 times, most recently from f5529e1 to 2ea4c4c Compare April 26, 2025 13:22
@jorenham jorenham self-requested a review April 26, 2025 14:26
@MarcoGorelli MarcoGorelli force-pushed the fix-ma-nomask-masktype branch from 2ea4c4c to f69a24c Compare April 26, 2025 14:54
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 26, 2025 15:42
@MarcoGorelli
Copy link
Member Author

thanks for your review!

@jorenham jorenham merged commit fb50a12 into numpy:main Apr 26, 2025
75 checks passed
@jorenham
Copy link
Member

Thanks Marco!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants