fix: broken sniff EmptyCommentSniff
#249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that this error is not something that is acceptable. This could maybe also be "fixed" by using the approach in this issue #242? |
|
@olivernybroe Can you double check this? |
nunomaduro
changed the title
EmptyCommentSniffEmptyCommentSniff
|
@nunomaduro sorry didn't have time to check it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sniff
EmptyCommentSniffdoesn't work well in legacy projects. Tried to contact the owner of the project here slevomat/coding-standard#688, but the owner doesn't have to have this sniff fixed.The only solution, for now, is remove the sniff. What do you guys think?