Skip to content

[Fix] assert ide is defined before resolving it #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2019
Merged

[Fix] assert ide is defined before resolving it #319

merged 2 commits into from
Nov 17, 2019

Conversation

Jibbarth
Copy link
Collaborator

Q A
Bug fix? yes
New feature? no
Fixed tickets #318

In default stub, we add 'ide' => null to configure url handle. However, this null value wasn't catched.

This is now fixed

@Jibbarth Jibbarth added the bug Something isn't working label Nov 17, 2019
@Jibbarth Jibbarth merged commit 91f8a81 into nunomaduro:master Nov 17, 2019
@Jibbarth Jibbarth deleted the fix/assert-ide-is-defined-before-resolving-it branch November 17, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

@olivernybroe olivernybroe Awaiting requested review from olivernybroe

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jibbarth @nunomaduro