[Feature] autofixer

[Jibbarth]

Q	A
Bug fix?	no
New feature?	yes
Fixed tickets	#54

Hey! I worked on autofix feature. It's not totally ready yet, but I wanted to create a PR to at least show you.

It add a --fix option to analyse command to apply check where it's possible during a complete analyze.
I also add a phpinsights fix command to don't get full report, but only apply fixes.

@caneco do you have idea on how improve the output ?

It's look like this for now:

TODO:

• Add tests
• Add documentations
• DefinitionResolver for booting container and create configuration (TODO in the code)
• Launch fix on all project (This will be done on another PR)

---

I'm also wondering if we should create a next branch for aggregate developments on v2.0 ? What do you think @nunomaduro @olivernybroe ?

[nunomaduro]

Nothing to say about the code, sounds good to me. Can I test this already locally?

[nunomaduro]

ps: @Jibbarth Very very good job.

[Jibbarth]

Can I test this already locally?

@nunomaduro Sure ! To test it on an other project, add this in composer.json

{
    //...
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/jibbarth/phpinsights"
        }
    ]
}

Then require phpinsights on correct branch :

composer require nunomaduro/phpinsights:dev-feature/autofixer

---

To get the code locally on your phpinsights folder, you could also add a remote on git:

git remote add jibbarth [email protected]:Jibbarth/phpinsights.git
git fetch jibbarth
git checkout feature/autofixer

And I think you can even push on my branch if you want, github allow edit for mainteners in PR 🙂

[olivernybroe]

The code looks great! Amazing work @Jibbarth

So how does the result look when using the other formatters? I guess the result is just as it normally looks when running without fixing?

[olivernybroe]

@Jibbarth @nunomaduro regarding creating a new branch for v2.0 stuff, I think we should consider making a branch for v.1 stuff instead and keep master for v2 stuff.

[nunomaduro]

@Jibbarth @olivernybroe For now, I don't see any breaking change here.

[zolotov88]

Hi! What about finish and relise this feature?

[Jibbarth]

@zolotov88 I'll try to work on this this weekend 😉

[zolotov88]

Yahoorei! =)

[YDoomA]

Hi) Bro, we are really looking forward to this release) You will have time to finish before the end of the week?)

[Jibbarth]

I think we only need to add the fix information to the other formatters and it should all be there.

@olivernybroe I added a "fixed issues" count in summary of Json Formatter.

For other, I don't think it's necessary (and I also don't know where to place it 😅)
For Checkstyle Formatter, we haven't summary field, and I think it's mainly used by CI to register issues.
Idem for GithubFormatter, as it's used to write issue on PR, it shouldn't be used with --fix option ?

WDYT ?

[olivernybroe]

I think that is fine for now :) If somebody says they can see a use-case in another formatter, a small pr can always be created.

[olivernybroe]

Nice! 👍

Just some small cleanup comments and I think we are there.

[nunomaduro]

Any chance we can get this under the 2.0 scope? #294

[olivernybroe]

Amazing!

I would say this is ready now 👍

[olivernybroe]

@Jibbarth if this is ready, then let's resolve the conflicts and get it merged 😄

[Jibbarth]

@olivernybroe I'll try to finish my pendings PRs tonight or during the weekend 😉

[Jibbarth]

@olivernybroe Conflicts fixed ! Could you redo a slight review ? 🙏

[olivernybroe]

LGTM! 👍
You can merge it in :)

[viezel]

Freaking fantastic 👏🏻👏🏻