Issues are sorted for all formatters

[bastien-phi]

Q	A
Bug fix?	no
New feature?	yes

I use a lot phpinsights and we keep a phpinsights.txt file inside our project repositories (basically just the output of php artisan insights --no-interaction -v). It helps us to see which issues are solved or created when we develop features.

Unfortunately, diffs are sometimes very hard to read because order in insights details can change between platforms (linux or macos) or for any other obscure reason.

Moreover, the fact that details are not sorted by file makes more difficult find the issue and fix then in batch. For example, a sample of what I got :

app/App/Admin/Filters/ByRuleTemplate.php:25: Unused parameter $request.
app/App/Dashboard/Controllers/UserController.php:54: Unused parameter $user
app/Support/Rules/HexColor.php:9: Unused parameter $attribute.
app/Support/Rules/ActivitySvg.php:17: Unused parameter $attribute.
app/Support/Rules/DomainName.php:17: Unused parameter $attribute.
app/Domain/User/Policies/UserPolicy.php:14: Unused parameter $admin.

This PR fixes this, sorting details of each insights, firstly by file, then line, function and finally message.

[olivernybroe]

Nice, I really like this and the implementation is clean.

Think this could help a lot of people figuring out what errors they are getting.

[Jibbarth]

👏 Looks great !

Do you think you could add some tests, especially for DetailComparator class ?

[bastien-phi]

@Jibbarth Should I add more test cases ?

[Jibbarth]

👍 Thank you @bastien-phi

[olivernybroe]

@bastien-phi Really nice! Could you add a test for the comparison order described in the PR, after that I'll say it is ready for merging 👍

[bastien-phi]

@olivernybroe is ee87ed0 what you wanted ?

[olivernybroe]

@bastien-phi Yep, it was something like that I had in mind, thanks a lot! ❤️