Fix #401 #402
Merged
Fix #401 #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use .phpcs.xml of project when loading FileFactory
nunomaduro
approved these changes
May 8, 2020
|
@nunomaduro Thanks 🤗 @olivernybroe Does this fix your issue ? |
olivernybroe
approved these changes
May 8, 2020
There was a problem hiding this comment.
@Jibbarth Nice this sounds like the correct issue 👍 Nice debugging!
I haven't tested it out yet to make sure it fixes it though.
However I'll greenlit it as I don't see anything wrong with doing this.
Prob. won't be able to test before next week.
50bhan
added a commit
to 50bhan/phpinsights
that referenced
this pull request
May 10, 2020
* upstream/master: Feature/syntax check (nunomaduro#373) Fix display detail message without file (nunomaduro#404) Fix nunomaduro#401 (nunomaduro#402) Update doc (add phpunit upgrade command) (nunomaduro#399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CF #401 (comment) the Config for PHPCS load .phpcs.xml from project.
That is useless for us, because we register sniff based on phpinsights.php configuration later, by file.
So I restore the standard config to remove this .phpcs.xml use, and restrict config to only 1 diff (without 1, the ruleset creation throw an error).