Skip to content

Feature/php8 and GitHub action #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 9, 2021
Merged

Feature/php8 and GitHub action #448

merged 14 commits into from
Feb 9, 2021

Conversation

Jibbarth
Copy link
Collaborator

Q A
Bug fix? no
New feature? yes
Fixed tickets #...

Hey 👋

This is a reopen PR, following #444. I hope that pushing my branch on the repository directly will trigger github Action...

Let's see !

@Jibbarth Jibbarth mentioned this pull request Dec 11, 2020
Closed
olivernybroe
olivernybroe approved these changes Dec 12, 2020
View reviewed changes
Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@andyksaw andyksaw mentioned this pull request Dec 22, 2020
Merged
6 tasks
@Jibbarth Jibbarth marked this pull request as ready for review December 24, 2020 11:22
@Pezhvak Pezhvak mentioned this pull request Jan 17, 2021
Closed
@Synchro
Copy link

Synchro commented Jan 28, 2021

Any chance of giving this a kick so it can be merged? The tests have passed but travis has stalled, probably just needs retriggering.

@ghost ghost mentioned this pull request Feb 3, 2021
Closed
@ghost
Copy link

ghost commented Feb 9, 2021

Any chance of giving this a kick so it can be merged? The tests have passed but travis has stalled, probably just needs retriggering.

Travis configuration was deleted in this PR, so naturally it won't trigger :)

@shrink
Copy link
Contributor

shrink commented Feb 9, 2021

Per the required label, someone with administrator permissions will need to remove the continuous-integration/travis-ci check.

@nunomaduro if you have a moment, are you able to action this? The steps are: Settings > Branches > master > Require status checks to pass before merging > uncheck continuous-integration/travis-ci -> save

Then this PR will be mergeable -- thanks!

@nunomaduro
Copy link
Owner

Done. @shrink

@Jibbarth
Copy link
Collaborator Author

Jibbarth commented Feb 9, 2021

Oh, great !

Thank you @nunomaduro and thank you @shrink for providing steps 💪

Let's merge this 🚀

@Jibbarth Jibbarth merged commit eed341b into master Feb 9, 2021
@Jibbarth Jibbarth deleted the feature/php8-and-github-action branch February 9, 2021 17:55
@Jibbarth Jibbarth mentioned this pull request Feb 14, 2021
Closed
This was referenced May 9, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivernybroe olivernybroe olivernybroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jibbarth @Synchro @shrink @nunomaduro @olivernybroe