-
-
Notifications
You must be signed in to change notification settings - Fork 286
Feature/composer version check #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/composer version check #473
Conversation
akosglue
commented
Apr 15, 2021
Q | A |
---|---|
Bug fix? | yes/no |
New feature? | yes/no |
Fixed tickets | #... |
I opened this PR accidentally here instead of my fork before it is ready. However it will target #417 |
@akosglue Thank you for your work! Just as a comment here, could you please change your PR and limit it to the necessary changes for this PR? Because I can see this PR is mixed up with another two PRs. |
9f841bd
to
27055fc
Compare
@50bhan if you look at 'Files changed' now, you seen only those 4 files that are related to this PR. |
@akosglue Yes, this is exactly what I meant! Thanks. |
32dd58e
to
d07ff80
Compare
d07ff80
to
33aa038
Compare
@50bhan would you be so kind as to look at these 2 failing checks? how is this related? I don't see it directly. |
7e32d63
to
57ec632
Compare
@50bhan indeed, it worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great improvement 🎉
Thank you @akosglue 👍