Skip to content

Feature/composer version check #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2021

Conversation

akosglue
Copy link

Q A
Bug fix? yes/no
New feature? yes/no
Fixed tickets #...

@akosglue
Copy link
Author

akosglue commented Apr 15, 2021

I opened this PR accidentally here instead of my fork before it is ready. However it will target #417
With this change it will be possible to disable the 'version' field check via the config (of course only with composer 2):
'config' => [ ComposerMustBeValid::class => [ 'composerVersionCheck' => false ] ],

@50bhan
Copy link
Contributor

50bhan commented Apr 15, 2021

@akosglue Thank you for your work! Just as a comment here, could you please change your PR and limit it to the necessary changes for this PR? Because I can see this PR is mixed up with another two PRs.

@akosglue akosglue force-pushed the feature/composer_version_check branch from 9f841bd to 27055fc Compare April 15, 2021 20:19
@akosglue
Copy link
Author

@50bhan if you look at 'Files changed' now, you seen only those 4 files that are related to this PR.
(2 fixtures, 1 test, 1 domain class)
Is it what you mean?
(the rest of the automatic checks will follow)

@50bhan
Copy link
Contributor

50bhan commented Apr 16, 2021

@akosglue Yes, this is exactly what I meant! Thanks.

@akosglue akosglue force-pushed the feature/composer_version_check branch from 32dd58e to d07ff80 Compare April 19, 2021 10:17
@akosglue akosglue closed this Apr 19, 2021
@akosglue akosglue force-pushed the feature/composer_version_check branch from d07ff80 to 33aa038 Compare April 19, 2021 10:27
@akosglue akosglue reopened this Apr 19, 2021
@akosglue
Copy link
Author

@50bhan would you be so kind as to look at these 2 failing checks? how is this related? I don't see it directly.

@50bhan
Copy link
Contributor

50bhan commented Apr 19, 2021

@akosglue Of course! I believe these failures are related to some dependency issues (as we have some problematic dependencies right now). So, I think I've fixed them already and made a PR for it (#477). We can merge that one first and then you can rebase and the CI failures might be fixed!

@50bhan
Copy link
Contributor

50bhan commented Apr 20, 2021

@akosglue The #478 PR has been merged and the problem with the CI failure does not exist anymore. You can rebase now and the tests will pass.

@akosglue
Copy link
Author

@50bhan indeed, it worked.

Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great improvement 🎉

Thank you @akosglue 👍

@Jibbarth Jibbarth linked an issue Apr 24, 2021 that may be closed by this pull request
@Jibbarth Jibbarth merged commit fc11cdd into nunomaduro:master Apr 24, 2021
@akosglue akosglue deleted the feature/composer_version_check branch April 25, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComposerMustBeValid: config option for version check
3 participants