Upgrade dependencies (PHP-CS-Fixer v3) #490
Conversation
| @@ -30,7 +30,7 @@ public function __construct() | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function diff($old, $new): string | |||
| public function diff(string $old, string $new, ?\SplFileInfo $file = null): string | |||
| { | |||
| return $this->differ->diff($old, $new); | |||
There was a problem hiding this comment.
| return $this->differ->diff($old, $new); | |
| return $this->differ->diff($old, $new, $file); |
There was a problem hiding this comment.
@Jibbarth It seems like they have changed the signature of the differ. So, if we're gonna use the third parameter ($file), we need to pass one parameter from the LongestCommonSubsequenceCalculator type. WDYT?
50bhan
force-pushed
the
feat/upgrade-dependencies
branch
from
7cfdce7 to
ced670e
Compare
Co-authored-by: Jibé Barth <[email protected]>
Co-authored-by: Jibé Barth <[email protected]>
50bhan
force-pushed
the
feat/upgrade-dependencies
branch
from
e04ba36 to
4f2d83a
Compare
50bhan
force-pushed
the
feat/upgrade-dependencies
branch
from
08626af to
337951d
Compare
|
@Jibbarth Can you help me with CI failure? And do we still need to support |
|
@50bhan sorry for the delay, vacation time (without computer 😉) I'll check |
As composer v2 as more than 6 month of existence, I think we could totally drop v1. Agree? |
|
@50bhan got a strange error on your branch. Seems the OrderedImportFixer is not executed (raised by test, and tested it also with binary). Do you get some fixer working ? |
Yes, I think we can remove it.
Actually, the problem is the CI is trying to install |
|
anything news? |
On PHP-CS-Fixer v3, a type has been used in an array_filter function of BraceFixer. As this constant is defined on codesniffer with a string, an error was raised and somes fixers wasn't executed
|
@Jibbarth Thank you for the fixes! I think now we can merge this PR right? |
|
Yep ! Thank you @50bhan 👍 |
This PR will close #476.
php-cs-fixerandphp-codesnifferbysymplify/easy-coding-standard, I believe we need to remove it.php-cs-fixerin version 3.0 is using"composer/xdebug-handler": "^2.0", and composer in version 2.0 is still using"composer/xdebug-handler": "^1.1". So, we need to wait for new release of composer.Rectorthat have been applied.php-cs-fixerinterfaces that need to be applied.