Fix path resolver when path start with directory separator

[50bhan]

Q	A
Bug fix?	yes
New feature?	no
Fixed tickets	#508

This PR will close #508.

[Jibbarth]

Hey @50bhan, just tested your implementation.

Given PHPInsights is installed globally, I execute it from my HOME directory.

$ phpinsights analyse /tmp/app 

This work and launch the analyse on the expected directory

$ phpinsights analyse /tmp

This doesn't work, raise the following exception :

  The "/home/barth/tmp" directory does not exist.  

So we have a regression here

[Jibbarth]

I think it's incorrect.

If I provide an absolute path (like /app), this shouldn't be resolved as current working dir + app.

[Jibbarth]

@50bhan, for me, the bug is here https://github.com/nunomaduro/phpinsights/blob/master/src/Infrastructure/Repositories/LocalFilesRepository.php#L66

Could be resolved like this

$this->directoryList[] = rtrim($pathInfo['dirname'], DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . $pathInfo['basename'];

But I'm not sure it'll work on Windows.

[50bhan]

@50bhan, for me, the bug is here https://github.com/nunomaduro/phpinsights/blob/master/src/Infrastructure/Repositories/LocalFilesRepository.php#L66

Could be resolved like this

$this->directoryList[] = rtrim($pathInfo['dirname'], DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . $pathInfo['basename'];

But I'm not sure it'll work on Windows.

Actually, this isn't the correct workaround. At first, I did the exact change that you've made. But the problem still remains:

[Jibbarth]

@50bhan i think it's the expected behaviour. When we pass an absolute path, it should be used.

But in the LocalFileRepository, it transform /app into //app

[50bhan]

@Jibbarth I was confused about it. If this is the case, the fix is easy as you said. I'll update the PR.

[Jibbarth]

Great ! If I found a Windows, I'll test against

[50bhan]

@Jibbarth Thanks, it would be awesome. I updated the PR.

Edit: Needed to upgrade Rector to avoid CI failure.

[Jibbarth]

Tested on Windows, bug was also present and now it's fixed 🎉

Thank you @50bhan 🙏