Skip to content

docs: Change docker example to be more robust. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

Potherca
Copy link
Contributor

@Potherca Potherca commented Jul 9, 2021

Q A
Bug fix? no
New feature? no
Fixed tickets no

The docker example uses pwd, but it is not wrapped in quotes ".

If the path returned by pwd contains a space character, docker will have an error:

docker: invalid reference format.

For people less familiar with docker, it can be quite unclear what is going wrong.

This MR fixes that issue by wrapping the call in quotes, so the path is passed to docker properly.

Copy link
Collaborator

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @Potherca 👍

@Jibbarth Jibbarth merged commit f00f88e into nunomaduro:master Jul 11, 2021
@Potherca Potherca deleted the docs/docker branch July 12, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants