Skip to content

minimal support for bigint #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2023
Merged

minimal support for bigint #1279

merged 2 commits into from
Feb 16, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Feb 16, 2023

closes #1278

@llimllib see if you can break this branch by passing bigints to unsuspected places (a build is available at https://observablehq.com/@observablehq/plot-bigint-1278 )… note that we're supporting bigints only as channel values, not as options (e.g. we don't try to support inset: 1n or margin: 10n).

As I was researching all the places where we coerce values to a number, I realized that this line is probably redundant, as we enter inferLogDomain only with already-coerced channels:

@Fil Fil requested a review from mbostock February 16, 2023 16:08
@llimllib
Copy link

I'll try to take a hack at it this afternoon 👍

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there are some further tweaks we can make to coercion but this seems like a good incremental step forward!

@Fil Fil merged commit cca578a into main Feb 16, 2023
@Fil Fil deleted the fil/bigint branch February 16, 2023 16:39
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimal support for bigints?
3 participants