Move __query and its dependencies to stdlib #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
approved these changes
Jul 1, 2022
annie
commented
Jul 1, 2022
| * of sub-strings and params are the parameter values to be inserted between each | ||
| * sub-string. | ||
| */ | ||
| export function makeQueryTemplate(operations, source) { |
There was a problem hiding this comment.
we still need this function in Next because we use it to construct the query for the convert to SQL operation. should we also export it as part of the standard library? that feels wrong somehow ... maybe there's another way to share the code?
There was a problem hiding this comment.
Yes we can have it as an export in src/index.mjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the __query function and its dependencies out of the Next worker code and into stdlib. I also moved a set of tests over for the query template function (which I renamed to
makeQueryTemplate, which I find a bit clearer).Once we upgrade stdlib in Classic, this will serve as a partial fix for Data Table embeds (embeds will show the array of results, but not the full table UI).