Add __table function and unit tests #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annie
commented
Oct 7, 2022
annie
commented
Oct 7, 2022
annie
changed the title
annie
changed the title
mbostock
reviewed
Oct 11, 2022
mbostock
reviewed
Oct 11, 2022
annie
commented
Oct 11, 2022
… throw if source isn't valid
mbostock
requested changes
Oct 12, 2022
Merged
mbostock
reviewed
Oct 12, 2022
* tweaks to __table * match expected schema * “resolved” table filter operands * test against sort mutation * remove export
libbey-observable
approved these changes
Oct 13, 2022
mbostock
approved these changes
Oct 13, 2022
mbostock
reviewed
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports over @mbostock's
__tablefunction, as defined in https://github.com/observablehq/observablehq/pull/8300, and adds missing support for theltandgtfilter operations. Also adds unit tests.