Skip to content

Remove .columns #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023
Merged

Remove .columns #365

merged 2 commits into from
May 11, 2023

Conversation

annie
Copy link
Contributor

@annie annie commented Apr 20, 2023

(Based on a suggestion from Mike)

Remove .columns from __table. It's no longer needed since we always guarantee that we'll return a .schema, and .schema is a superset of the information in .columns.

One thing I'm not too sure about – if the source has a .columns property and the source isn't modified in __table, the .columns property will pass through and remain in the output. Is that ok, or do we need to standardize __table by making sure .schema is the only property on the output?

Copy link
Contributor

@libbey-observable libbey-observable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. If a source comes in to __table() with .columns and thus passes through and gets returned with .columns, that seems okay to me, but if we want to dig in deeper on that I'd be up for that, too.

@annie
Copy link
Contributor Author

annie commented Apr 28, 2023

yep that makes sense to me! thinking about it a bit more, there could be any number of properties on source that we just pass through right now, so it makes sense to treat .columns as just one of those.

@annie annie merged commit 9f01d7a into main May 11, 2023
@annie annie deleted the annie/rm-columns branch May 11, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants