Skip to content

chore: adjust noisy log lines #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

chore: adjust noisy log lines #1268

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da76cd1
chore: adjust noisy log lines
toddbaert Mar 7, 2025
388d206
fixup: combine debug lines
toddbaert Mar 10, 2025
7e6eb5e
Merge branch 'main' into chore/clean-up-logs
toddbaert Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ EvaluationContext getEnrichedContext() {

@SuppressWarnings("checkstyle:fallthrough")
private void onProviderEvent(FlagdProviderEvent flagdProviderEvent) {
log.info("FlagdProviderEvent event {} ", flagdProviderEvent.getEvent());
log.debug("FlagdProviderEvent event {} ", flagdProviderEvent.getEvent());
synchronized (syncResources) {
/*
* We only use Error and Ready as previous states.
Expand Down Expand Up @@ -231,7 +231,7 @@ private void onProviderEvent(FlagdProviderEvent flagdProviderEvent) {
break;

default:
log.info("Unknown event {}", flagdProviderEvent.getEvent());
log.warn("Unknown event {}", flagdProviderEvent.getEvent());
}
}
}
Expand All @@ -245,7 +245,7 @@ private void onConfigurationChanged(FlagdProviderEvent flagdProviderEvent) {

private void onReady() {
if (syncResources.initialize()) {
log.info("initialized FlagdProvider");
log.info("Initialized FlagdProvider");
}
if (errorTask != null && !errorTask.isCancelled()) {
errorTask.cancel(false);
Expand All @@ -256,7 +256,7 @@ private void onReady() {
}

private void onError() {
log.info("Connection lost. Emit STALE event...");
log.debug("Stream error. Emitting STALE event and scheduling ERROR event...");
log.debug("Waiting {}s for connection to become available...", gracePeriod);
this.emitProviderStale(ProviderEventDetails.builder()
.message("there has been an error")
Expand All @@ -271,7 +271,7 @@ private void onError() {
() -> {
if (syncResources.getPreviousEvent() == ProviderEvent.PROVIDER_ERROR) {
log.debug(
"Provider did not reconnect successfully within {}s. Emit ERROR event...",
"Provider did not reconnect successfully within {}s. Emitting ERROR event...",
gracePeriod);
flagResolver.onError();
this.emitProviderError(ProviderEventDetails.builder()
Expand Down
6 changes: 3 additions & 3 deletions ...main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,18 @@ public void init() throws Exception {
flagStore.getStateQueue().take();
switch (storageStateChange.getStorageState()) {
case OK:
log.info("onConnectionEvent.accept ProviderEvent.PROVIDER_CONFIGURATION_CHANGED");
log.debug("onConnectionEvent.accept ProviderEvent.PROVIDER_CONFIGURATION_CHANGED");
onConnectionEvent.accept(new FlagdProviderEvent(
ProviderEvent.PROVIDER_CONFIGURATION_CHANGED,
storageStateChange.getChangedFlagsKeys(),
storageStateChange.getSyncMetadata()));
log.info("post onConnectionEvent.accept ProviderEvent.PROVIDER_CONFIGURATION_CHANGED");
log.debug("post onConnectionEvent.accept ProviderEvent.PROVIDER_CONFIGURATION_CHANGED");
break;
case ERROR:
onConnectionEvent.accept(new FlagdProviderEvent(ProviderEvent.PROVIDER_ERROR));
break;
default:
log.info(String.format(
log.warn(String.format(
"Storage emitted unhandled status: %s", storageStateChange.getStorageState()));
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/FlagStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ private void streamerListener(final QueueSource connector) throws InterruptedExc
}
break;
default:
log.info(String.format("Payload with unknown type: %s", payload.getType()));
log.warn(String.format("Payload with unknown type: %s", payload.getType()));
}
}

Expand Down
Loading