build: add maven wrapper & update docs #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandraoberaigner
force-pushed
the
feature/add-maven-wrapper
branch
from
38a1614 to
d43c169
Compare
alexandraoberaigner
changed the title
|
Does it make sense to also adopt the build files to use the maven wrapper? |
Signed-off-by: Alexandra Oberaigner <[email protected]> Co-Authored-By: Daniel Zehetner <[email protected]> Co-Authored-By: Simon Schrottner <[email protected]>
Kavindu-Dodan
force-pushed
the
feature/add-maven-wrapper
branch
from
d43c169 to
6c690c5
Compare
hmm, this will require an upgrade to github action and add the same to other providers in this repository. I think having wrapper for flagd for now is sufficient for ease of use. |
Kavindu-Dodan
approved these changes
Jun 7, 2024
zedadyna
pushed a commit
to zedadyna/java-sdk-contrib
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Alexandra Oberaigner <[email protected]> Signed-off-by: Daniel Zehetner <[email protected]>
zedadyna
pushed a commit
to zedadyna/java-sdk-contrib
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Alexandra Oberaigner <[email protected]> Signed-off-by: Daniel Zehetner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
We are adding the maven wrapper to simplify project setup for contributing.
How to test
run
./mvnw -version