-
Notifications
You must be signed in to change notification settings - Fork 18
feat(flagd): Add features to customize auth to Sync API servers #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maks Osowski <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 94.28% 93.96% -0.33%
==========================================
Files 18 18
Lines 928 945 +17
==========================================
+ Hits 875 888 +13
- Misses 53 57 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi, I am new in this repo :) Could you please advise about those failing checks? Thanks! |
Hey @cupofcat, it looks like you're running into a lint and type issue. It looks like you may be able to reproduce the lint issue locally by using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 🍻 left a few minor comments
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/provider.py
Outdated
Show resolved
Hide resolved
...der-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
Show resolved
Hide resolved
...der-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
Show resolved
Hide resolved
...der-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
Show resolved
Hide resolved
@cupofcat if you have issues with fixing the failing type check, let me know and I can fix it for you. |
Signed-off-by: Maks Osowski <[email protected]>
Code looks good, let's wait a bit, if someone else has an opinion on it. if not, then I'll merge it next week. |
Hi there! Is there anything you would like me to change in this PR? Thanks! |
This PR
Notes
This is similar to recent changes for Go & Java: