Skip to content

feat(flagd): Add features to customize auth to Sync API servers #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

@cupofcat cupofcat requested a review from a team as a code owner March 5, 2025 17:11
@beeme1mr beeme1mr requested a review from aepfli March 5, 2025 17:46
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.96%. Comparing base (6495dc0) to head (b32b404).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../flagd/resolvers/process/connector/grpc_watcher.py 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   94.28%   93.96%   -0.33%     
==========================================
  Files          18       18              
  Lines         928      945      +17     
==========================================
+ Hits          875      888      +13     
- Misses         53       57       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cupofcat
Copy link
Contributor Author

cupofcat commented Mar 5, 2025

Hi, I am new in this repo :) Could you please advise about those failing checks? Thanks!

@beeme1mr
Copy link
Member

beeme1mr commented Mar 5, 2025

Hey @cupofcat, it looks like you're running into a lint and type issue. It looks like you may be able to reproduce the lint issue locally by using pre-commit run --all-files. I believe you can reproduce the type issue locally by running hatch run mypy:run.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🍻 left a few minor comments

@gruebel
Copy link
Member

gruebel commented Mar 5, 2025

@cupofcat if you have issues with fixing the failing type check, let me know and I can fix it for you.

@gruebel
Copy link
Member

gruebel commented Mar 6, 2025

Code looks good, let's wait a bit, if someone else has an opinion on it. if not, then I'll merge it next week.

@cupofcat
Copy link
Contributor Author

cupofcat commented Mar 8, 2025

Hi there! Is there anything you would like me to change in this PR? Thanks!

@gruebel gruebel merged commit 5151e94 into open-feature:main Mar 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants