Skip to content

Please use standard CMake variable to configure static vs. shared builds #51

Closed
@mwoehlke-kitware

Description

@mwoehlke-kitware

When building jsoncpp as part of a "superbuild" of a larger project, I was surprised that it build a static library. I see this is because shared vs. static is configured by the JSONCPP_LIB_BUILD_SHARED option and not the standard CMake option BUILD_SHARED_LIBS.

Is there a reason you cannot use the latter? Please do so if possible, or at least default JSONCPP_LIB_BUILD_SHARED to ${BUILD_SHARED_LIBS} rather than OFF.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions