Add nullptr Json::Value constructor #1194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some unexpected behavior when using this library when comparing a
Json::Value
tonullptr
. This was my sample program:Since before this change,
Json::Value
objects can be compared with otherJson::Value
objects, a implicitJson::Value
object will be constructed withnullptr
as it's parameters. Given the only valid constructor fornullptr
was theconst char *
, the program aborts with the following output:To improve this experience, I've explicitly deleted the
nullptr_t
constructor, so that the above code will result in a compile time error.