Roll version numbers for 1.9.4 release #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ | |||
| // 3. /CMakeLists.txt | |||
| // IMPORTANT: also update the SOVERSION!! | |||
|
|
|||
| #define JSONCPP_VERSION_STRING "1.9.3" | |||
| #define JSONCPP_VERSION_STRING "1.9.4" | |||
| #define JSONCPP_VERSION_MAJOR 1 | |||
| #define JSONCPP_VERSION_MINOR 9 | |||
| #define JSONCPP_VERSION_PATCH 3 | |||
There was a problem hiding this comment.
updating the PATCH here was missed.
There was a problem hiding this comment.
Also
#define JSONCPP_VERSION_PATCH 3
|
This was merged before AppVeyor had passed. Not good! I'm trying to figure out when TravisCI stopped running. We're lucky AppVeyor still works I think. |
|
Weird. My latest PR failed in TravisCI -- so obviously it did run in TravisCI -- but there is no TravisCI notification in GitHub. Possibly related: https://travis-ci.community/t/github-ci-notifiactions-from-travis-stopped-working/9238/3 Still investigating ... |
|
Fixed it by adding a new "Branch Protection Rule". No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.