Fix empty version string in pkgconfig/jsoncpp.pc

[dota17]

Hi @AmarOk1412 Please check if this patch fix your problem.

Fix #1235

[AmarOk1412]

File: pkg-config/jsoncpp.pc
────────────────────────────────────────────────────────
prefix=/usr/local
exec_prefix=/usr/local
libdir=${exec_prefix}/lib64
includedir=${prefix}/include

Name: jsoncpp
Description: A C++ library for interacting with JSON
Version: 1.9.4
URL: https://github.com/open-source-parsers/jsoncpp
Libs: -L${libdir} -ljsoncpp
Cflags: -I${includedir}

Looks good :)

[baylesj]

I was curious how this happened, it looks like its a result of this patch, which removed cmake JSONCPP_ prepended fields in favor of PROJECT_ field, in this case JSONCPP_VERSION got changed toPROJECT_VERSION.

I think we can actually go further with this patch and remove all references to JSONCPP_VERSION.

[baylesj]

@cdunn2001 or @BillyDonahue, do you think any projects are going to be checking the JSONCPP_VERSION* fields? If so, I'm wondering if the right answer is to actually batch replace PROJECT_VERSION* with JSONCPP_VERSION* (essentially partially reverting #1197).

[dota17]

@baylesj Sorry, my bad, you are right. I shouldn't change the project setting in CMakelists.txt.
I didn't know that <PROJECT-NAME>_VERSION and PROJECT_VERSION are the same[1,2], so there is no need to change the project name from JSONCPP to jsoncpp.
So, based on this, I agree with you to partially reverting #1197, use JSONCPP_VERSION and JSONCPP_VERSION_MAJOR again.

[cdunn2001]

I honestly have no opinion on any cmake changes. I'd aim for minimal maintenance, but I wouldn't object to any cmake changes.

[AmarOk1412]

Note here: with the PR I still have an undetected JSONCPP version
It's for building https://github.com/savoirfairelinux/opendht

[dota17]

@AmarOk1412
Could you please tell more detail?

[coveralls]

Coverage remained the same at 93.803% when pulling ba68da9 on jsoncpp_version into 8954092 on master.

[LocutusOfBorg]

For Debian, I went for a minimal approach:

--- libjsoncpp-1.9.4.orig/CMakeLists.txt
+++ libjsoncpp-1.9.4/CMakeLists.txt
@@ -73,6 +73,7 @@ project(jsoncpp
         LANGUAGES CXX)

 message(STATUS "JsonCpp Version: ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}")
+set(JSONCPP_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH})
 set(PROJECT_SOVERSION 24)

 option(JSONCPP_WITH_TESTS "Compile and (for jsoncpp_check) run JsonCpp test executables" ON)

[cdunn2001]

I guess #1235 fixed this? Please re-open if not.