CMake: Unique lib target name #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @cdunn2001 |
|
We strongly prefer meson to cmake, but if you are confident in this change, go ahead and merge. You might help other cmake users. |
cdunn2001
approved these changes
Dec 2, 2018
|
@cdunn2001 I dont have rights to merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue when using the imported target from the cmake config file is that the target name differs whether the lib is compiled statically of dynamically so the client code cannot know easily whether to use the dynamic name (jsoncpp_lib) or the static name (jsoncpp_lib_static).
This PR sets a unique name for the lib so the client code can always use:
Also BUILD_STATIC_LIBS is unused and not standard.
And also use CMAKE_CROSSCOMPILING_EMULATOR to run tests when cross-compiling.