-
Notifications
You must be signed in to change notification settings - Fork 3k
Add build for arm64 arch #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@austinlparker is this still needed? I thought we do multi-arch builds already. |
We do not do multi arch builds because it takes like 4+ hours. |
I have added it in particular because the featureflagservice keeps segfaulting on my M1 device with and without emulation. I think it makes a lot of sense to have this available for multiple architectures. If the build time is a problem, it's probably a question of optimization |
I also thought we fixed this but I just tried installing the helm chart locally again and featureflag service is crashing again (open-telemetry/opentelemetry-helm-charts#580). Is there a way that we can do the existing build and publish process and separately build a specific arm64 image either after the existing build finishes or in parallel? |
We sure could. Not sure if this benefits us. Currently all images are built in parallel and in each build sequentially builds and pushed amd64 and arm64. I would argue there is a fair amount of parallelism already in place. Current duration for the |
No, it takes about 4 hours: https://github.com/open-telemetry/opentelemetry-demo/actions/runs/3313405848 It might be better now with some of the optimizations we've made to build time but Rust and C++ images take forever to build under emulation. I would suggest modifying the GHA runner file here to allow builds for PR's (you need to modify the |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I went ahead and tested this out on our runner config -- everything builds OK. Shipping service takes an hour which isn't great, but we can work on getting that down. |
* Add build for arm64 arch * Add change to changelog * enable build on PR * remove build on pr --------- Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Austin Parker <[email protected]>
Changes
This change introduces another architecture for the images created: arm64
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.