Skip to content

feat: support multi-value key propagation extraction #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iunanua
Copy link

@iunanua iunanua commented May 28, 2025

Changes

Modify opentelemetry::propagation::Extractor trait adding the new get_all method in order to make possible to handle keys with multiple values.
Also implement get_all method for opentelemetry_http::HeaderExtractor

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

linux-foundation-easycla bot commented May 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cijothomas / name: Cijo Thomas (a8d975e)
  • ✅ login: iunanua / name: Igor Unanua (72f64fb, 8dcbb69)

Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.0%. Comparing base (28becc0) to head (a8d975e).

Files with missing lines Patch % Lines
opentelemetry-http/src/lib.rs 92.5% 2 Missing ⚠️
opentelemetry/src/propagation/mod.rs 90.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3008   +/-   ##
=====================================
  Coverage   81.0%   81.0%           
=====================================
  Files        126     126           
  Lines      24821   24868   +47     
=====================================
+ Hits       20109   20152   +43     
- Misses      4712    4716    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iunanua iunanua changed the title Support for multi-value key propagation extraction feat: support multi-value key propagation extraction May 28, 2025
@iunanua iunanua marked this pull request as ready for review May 30, 2025 10:01
@iunanua iunanua requested a review from a team as a code owner May 30, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants