Add tool call parameters for on_tool_start hook
#253
+43
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini-peanut
reviewed
Mar 25, 2025
| ( | ||
| agent.hooks.on_tool_start(context_wrapper, agent, func_tool) | ||
| agent.hooks.on_tool_start(context_wrapper, agent, func_tool, tool_call.arguments) | ||
| if agent.hooks |
There was a problem hiding this comment.
Since using only arguments as a parameter is too granular, and adding tool_call.id in the future would lead to parameter inflation at the root level, plus tool_call.id is actually needed, would it be better to pass the entire tool_call object as a parameter instead?"
There was a problem hiding this comment.
@mini-peanut Thanks for your review! I've updated the hook to use Action, which not only includes the Tool but also contains the instance information for a tool call, including the parameters and tool_call.id.
|
@yanmxa thanks for doing this work, very useful! |
yanmxa
force-pushed
the
br_tool_hooks
branch
3 times, most recently
from
4724b5e to
c3287fd
Compare
Signed-off-by: myan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #252