Skip to content

Replace referencable_id with response_id #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Replace referencable_id with response_id #508

merged 1 commit into from
Apr 15, 2025

Conversation

rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented Apr 14, 2025 •
edited
Loading

Minor change - naming. So that it doesn't pollute the next PR.

@rm-openai rm-openai mentioned this pull request Apr 14, 2025
Merged
@rm-openai rm-openai requested a review from pakrym-oai April 15, 2025 01:32
@rm-openai rm-openai merged commit d6f5190 into main Apr 15, 2025
5 checks passed
@rm-openai rm-openai deleted the rm/pr508 branch April 15, 2025 01:37
@rm-openai rm-openai mentioned this pull request Apr 15, 2025
Merged
rm-openai added a commit that referenced this pull request Apr 15, 2025
@rm-openai
Previous response id (#509)
92d6e3e 
Allows passing in the previous_response_id to reduce sending the same
data again and again.

Test plan:
Examples. Adding tests in next PR shortly.

---
[//]: # (BEGIN SAPLING FOOTER)
* __->__ #509
* #508
@rm-openai rm-openai linked an issue Apr 15, 2025 that may be closed by this pull request
Why full history as input is still necessary? #102
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-oai pakrym-oai pakrym-oai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why full history as input is still necessary?
2 participants
@rm-openai @pakrym-oai