8355561: [macos] Build failure with Xcode 16.3 #24937

mrserb · 2025-04-28T19:47:03Z

Multiple similar issues detected in PLATFORM_API_MacOSX_Ports.cpp more info about llvm/llvm-project#62836

jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_Ports.cpp:127:39: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
127 | AudioDeviceID devices[count];
| ^~~~~
jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_Ports.cpp:127:39: note: read of non-const variable 'count' is not allowed in a constant expression
jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_Ports.cpp:126:21: note: declared here
126 | int count = size/sizeof(AudioDeviceID);

The usage of VLA has been replaced with malloc/calloc and free, which are already used in this file.

Note that while this patch adds some validation, I am pretty sure it is still possible to crash these code paths if they are executed concurrently. Access to the native pointers being passed around is not properly synchronized.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8355561: [macos] Build failure with Xcode 16.3 (Bug - P3)

Reviewers

Alexander Zuev (@azuev-java - Reviewer)
Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24937/head:pull/24937
$ git checkout pull/24937

Update a local copy of the PR:
$ git checkout pull/24937
$ git pull https://git.openjdk.org/jdk.git pull/24937/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24937

View PR using the GUI difftool:
$ git pr show -t 24937

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24937.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-28T19:48:04Z

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-28T19:48:10Z

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355561: [macos] Build failure with Xcode 16.3

Reviewed-by: kizune, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 192 new commits pushed to the master branch:

4977588: 8330022: Failure test/hotspot/jtreg/vmTestbase/nsk/sysdict/share/BTreeTest.java: Could not initialize class java.util.concurrent.ThreadLocalRandom
fe29cad: 8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output"
0cb355e: 8356096: ISO 4217 Amendment 179 Update
... and 189 more: https://git.openjdk.org/jdk/compare/6254046f508049a4e568f0f2eae51dc10da392c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-28T19:48:55Z

@mrserb The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mrserb · 2025-04-28T19:51:52Z

/reviewers 2

openjdk · 2025-04-28T19:52:47Z

@mrserb
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

mrserb · 2025-04-28T21:46:30Z

src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_Ports.cpp

@@ -229,6 +237,9 @@ INT32 PORT_GetPortMixerDescription(INT32 mixerIndex, PortMixerDescription* mixer
 void* PORT_Open(INT32 mixerIndex) {
    TRACE1("\n>>PORT_Open (mixerIndex=%d)\n", (int)mixerIndex);
    PortMixer *mixer = (PortMixer *)calloc(1, sizeof(PortMixer));
+    if (!mixer) {
+        return nullptr;
+    }


This is a pre-existing bug; the caller code is already prepared to handle null.

jdk/src/java.desktop/share/classes/com/sun/media/sound/PortMixer.java

Line 76 in 62d165d

id = nOpen(getMixerIndex());

->

jdk/src/java.desktop/share/native/libjsound/PortMixer.c

Line 45 in 62d165d

ret = (jlong) (INT_PTR) PORT_Open(mixerIndex);

-> PORT_Open

mlbridge · 2025-04-28T21:55:19Z

Webrevs

00: Full (3b86763b)

mrserb · 2025-04-28T22:00:07Z

Note that the build is broken not only due to this issue, but also due to another recently introduced problem, which is mentioned in the following link: #24608 (comment).

TheShermanTanker · 2025-04-30T10:29:36Z

Why not new and delete?

mrserb · 2025-04-30T18:12:27Z

Why not new and delete?

In most cases, we allocate raw buffers that are filled by macOS. We could use "std::vector+try/catch" instead, but since malloc/free is already used in this code, I followed the same pattern for consistency.

azuev-java

Looks good.

archiecobbs · 2025-05-05T13:53:45Z

Looking forward to getting this fixed so I can build again...

mrserb · 2025-05-07T02:53:43Z

/integrate

openjdk · 2025-05-07T02:54:44Z

Going to push as commit 762423d.
Since your change was applied there have been 197 commits pushed to the master branch:

acad0b4: 8356188: RISC-V: Cleanup effect of vmaskcmp_fp
cbbab07: 8356309: Fix issues uncovered after running jpackage tests locally with installing test packages
9a23f72: 8316682: serviceability/jvmti/vthread/SelfSuspendDisablerTest timed out
... and 194 more: https://git.openjdk.org/jdk/compare/6254046f508049a4e568f0f2eae51dc10da392c1...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-05-07T02:54:57Z

@mrserb Pushed as commit 762423d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Update PLATFORM_API_MacOSX_Ports.cpp

3b86763

openjdk bot added the client [email protected] label Apr 28, 2025

mrserb commented Apr 28, 2025

View reviewed changes

mrserb marked this pull request as ready for review April 28, 2025 21:51

openjdk bot added the rfr Pull request is ready for review label Apr 28, 2025

azuev-java approved these changes May 5, 2025

View reviewed changes

prrace approved these changes May 6, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 6, 2025

openjdk bot added the integrated Pull request has been integrated label May 7, 2025

openjdk bot closed this May 7, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2025

mrserb deleted the sound_2 branch May 7, 2025 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8355561: [macos] Build failure with Xcode 16.3 #24937

8355561: [macos] Build failure with Xcode 16.3 #24937

Uh oh!

mrserb commented Apr 28, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Apr 28, 2025

Uh oh!

openjdk bot commented Apr 28, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Apr 28, 2025

Uh oh!

mrserb commented Apr 28, 2025

Uh oh!

openjdk bot commented Apr 28, 2025

Uh oh!

mrserb Apr 28, 2025 •

edited

Loading

Uh oh!

mlbridge bot commented Apr 28, 2025

Uh oh!

mrserb commented Apr 28, 2025

Uh oh!

TheShermanTanker commented Apr 30, 2025

Uh oh!

mrserb commented Apr 30, 2025

Uh oh!

azuev-java left a comment

Uh oh!

archiecobbs commented May 5, 2025

Uh oh!

mrserb commented May 7, 2025

Uh oh!

openjdk bot commented May 7, 2025

Uh oh!

openjdk bot commented May 7, 2025

Uh oh!

Uh oh!

8355561: [macos] Build failure with Xcode 16.3 #24937

8355561: [macos] Build failure with Xcode 16.3 #24937

Uh oh!

Conversation

mrserb commented Apr 28, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 28, 2025

Uh oh!

openjdk bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 28, 2025

Uh oh!

mrserb commented Apr 28, 2025

Uh oh!

openjdk bot commented Apr 28, 2025

Uh oh!

mrserb Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mlbridge bot commented Apr 28, 2025

Webrevs

Uh oh!

mrserb commented Apr 28, 2025

Uh oh!

TheShermanTanker commented Apr 30, 2025

Uh oh!

mrserb commented Apr 30, 2025

Uh oh!

azuev-java left a comment

Choose a reason for hiding this comment

Uh oh!

archiecobbs commented May 5, 2025

Uh oh!

mrserb commented May 7, 2025

Uh oh!

openjdk bot commented May 7, 2025

Uh oh!

openjdk bot commented May 7, 2025

Uh oh!

Uh oh!

mrserb commented Apr 28, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 28, 2025 •

edited

Loading

mrserb Apr 28, 2025 •

edited

Loading