Skip to content

Update handling of multiple headers changed in nginx 1.23.0 #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions src/ngx_http_lua_headers_in.c
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,15 @@ static ngx_http_lua_set_header_t ngx_http_lua_set_handlers[] = {
ngx_http_set_builtin_header },
#endif

#if defined(nginx_version) && nginx_version >= 1023000
{ ngx_string("Cookie"),
offsetof(ngx_http_headers_in_t, cookie),
ngx_http_set_builtin_multi_header },
#else
{ ngx_string("Cookie"),
offsetof(ngx_http_headers_in_t, cookies),
ngx_http_set_builtin_multi_header },
#endif

{ ngx_null_string, 0, ngx_http_set_header }
};
Expand Down Expand Up @@ -580,6 +586,45 @@ static ngx_int_t
ngx_http_set_builtin_multi_header(ngx_http_request_t *r,
ngx_http_lua_header_val_t *hv, ngx_str_t *value)
{
#if defined(nginx_version) && nginx_version >= 1023000
ngx_table_elt_t **headers, **ph, *h;
int nelts;

headers = (ngx_table_elt_t **) ((char *) &r->headers_in + hv->offset);

if (!hv->no_override && *headers != NULL) {
nelts = 0;
for (h = *headers; h; h = h->next) {
nelts++;
}

*headers = NULL;

dd("clear multi-value headers: %d", nelts);
}

if (ngx_http_set_header_helper(r, hv, value, &h) == NGX_ERROR) {
return NGX_ERROR;
}

if (value->len == 0) {
return NGX_OK;
}

dd("new multi-value header: %p", h);

if (*headers) {
for (ph = headers; *ph; ph = &(*ph)->next) { /* void */ }
*ph = h;

} else {
*headers = h;
}

h->next = NULL;

return NGX_OK;
#else
ngx_array_t *headers;
ngx_table_elt_t **v, *h;

Expand Down Expand Up @@ -626,6 +671,7 @@ ngx_http_set_builtin_multi_header(ngx_http_request_t *r,

*v = h;
return NGX_OK;
#endif
}


Expand Down
63 changes: 63 additions & 0 deletions src/ngx_http_lua_headers_out.c
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,68 @@ static ngx_int_t
ngx_http_set_builtin_multi_header(ngx_http_request_t *r,
ngx_http_lua_header_val_t *hv, ngx_str_t *value)
{
#if defined(nginx_version) && nginx_version >= 1023000
ngx_table_elt_t **headers, *h, *ho, **ph;

headers = (ngx_table_elt_t **) ((char *) &r->headers_out + hv->offset);

if (hv->no_override) {
for (h = *headers; h; h = h->next) {
if (!h->hash) {
h->value = *value;
h->hash = hv->hash;
return NGX_OK;
}
}

goto create;
}

/* override old values (if any) */

if (*headers) {
for (h = (*headers)->next; h; h = h->next) {
h->hash = 0;
h->value.len = 0;
}

h = *headers;

h->value = *value;

if (value->len == 0) {
h->hash = 0;

} else {
h->hash = hv->hash;
}

return NGX_OK;
}

create:
for (ph = headers; *ph; ph = &(*ph)->next) { /* void */ }

ho = ngx_list_push(&r->headers_out.headers);
if (ho == NULL) {
return NGX_ERROR;
}

ho->value = *value;

if (value->len == 0) {
ho->hash = 0;

} else {
ho->hash = hv->hash;
}

ho->key = hv->key;
ho->next = NULL;
*ph = ho;

return NGX_OK;
#else
ngx_array_t *pa;
ngx_table_elt_t *ho, **ph;
ngx_uint_t i;
Expand Down Expand Up @@ -384,6 +446,7 @@ ngx_http_set_builtin_multi_header(ngx_http_request_t *r,
*ph = ho;

return NGX_OK;
#endif
}


Expand Down