Skip to content

John/link #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 12, 2024
Merged

John/link #53

merged 9 commits into from
Mar 12, 2024

Conversation

johnwdunn20
Copy link
Collaborator

@johnwdunn20 johnwdunn20 commented Mar 11, 2024 •
edited
Loading

  • Added scripts to link package - see package-react/DevelopmentSteps.md for details
  • Moved everything in example/link to the src folder so it builds properly
  • Updated github actions. Confirmed testing works correctly. Deploy to chrome is complicated and npm publish needs to be tested on pushes to main

@johnwdunn20 johnwdunn20 marked this pull request as ready for review March 11, 2024 23:29
austin-cavanagh
austin-cavanagh approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@austin-cavanagh austin-cavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good John, great work.

@austin-cavanagh austin-cavanagh merged commit 47e231d into dev Mar 12, 2024
@johnwdunn20 johnwdunn20 deleted the john/link branch May 8, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin-cavanagh austin-cavanagh austin-cavanagh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnwdunn20 @austin-cavanagh