Skip to content

Proposed fix for msc_process_request_body call too early #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Proposed fix for msc_process_request_body call too early #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/mod_security3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ static int hook_request_late(request_rec *r)
return it;
}
#endif
msc_process_request_body(msr->t);
// FIXME: memsc_append_request_body wasn't called yet. Too early?
// msc_process_request_body(msr->t);
it = process_intervention(msr->t, r);
if (it != N_INTERVENTION_STATUS)
{
Expand Down
3 changes: 3 additions & 0 deletions src/msc_filters.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ apr_status_t input_filter(ap_filter_t *f, apr_bucket_brigade *pbbOut,
return send_error_bucket(msr, f, it);
}

// FIXME: Now we should have the body. Is this sane?
msc_process_request_body(msr->t);

pbktOut = apr_bucket_heap_create(data, len, 0, c->bucket_alloc);
APR_BRIGADE_INSERT_TAIL(pbbOut, pbktOut);
apr_bucket_delete(pbktIn);
Expand Down