Skip to content

Fixed data collecting in multipart parsing #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed data collecting in multipart parsing #2016

wants to merge 2 commits into from

Conversation

airween
Copy link
Member

@airween airween commented Feb 1, 2019

  • the FILES_NAMES collection was empty after the end of multipart parsing, fixed it
  • added regression test case

@victorhora victorhora added enhancement 3.x Related to ModSecurity version 3.x and removed enhancement labels Feb 2, 2019
@victorhora victorhora added this to the v3.0.4 milestone Feb 2, 2019
@airween
Copy link
Member Author

airween commented Feb 2, 2019

Looks like the existing test cases were wrong, checked same variable values. The second commit (7c6c610) fixes them, now all build completed.

zimmerle added a commit that referenced this pull request Feb 12, 2019
@zimmerle
CHANGES: Adds info about #2016
b392a1c
@zimmerle
Copy link
Contributor

Merged! Thanks!

@zimmerle zimmerle closed this Feb 12, 2019
@airween airween mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimmerle zimmerle Awaiting requested review from zimmerle

@victorhora victorhora Awaiting requested review from victorhora

Assignees

@zimmerle zimmerle

@victorhora victorhora

Labels
3.x Related to ModSecurity version 3.x
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@airween @zimmerle @victorhora