Allow empty anchored variable to use #2024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhora
added
enhancement
3.x
zimmerle
added a commit
that referenced
this pull request
Feb 12, 2019
|
Merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that when a SecRule contains an negated operator (eg. "!@ENDSWITH .pdf"), and the variable is empty (eg. REQUEST_BASENAME, and the query is a simple "GET /"), then the result of negated evaluate of empty variable will TRUE. Then the rule interpreted as the GET / IS endsWith .pdf, so it will generate a false positive match.
I don't see the reason why didn't allowed the empty variable previously, but this patch fix this bug above, and all other test result keep as PASSED.
See the rule-920200.json regression test file, which inspired the CRS id 920200 and its test.