Skip to content

V3/issue 1960 #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

airween
Copy link
Member

@airween airween commented Feb 22, 2019

Fixed #1960.

@airween
Copy link
Member Author

airween commented Feb 22, 2019

Alternative solution to ignore the sent modification, and grab the intervention in each affected (disruptive) actions, eg:

    if (transaction->m_it.status == 200) {
        transaction->m_it.status = 403;
    }

replace this to

    if (transaction->getRuleEngineState() != RulesProperties::DetectionOnlyRuleEngine) {
        if (transaction->m_it.status == 200) {
            transaction->m_it.status = 403;
        }
    }

In this case, in the late phases the HTTP server response doesn't lost.

As I see, these actions are affected: deny, drop and may be the redirect.

Any idea?

@airween
Copy link
Member Author

airween commented Feb 23, 2019

Argh... this error comes again and again...
https://travis-ci.org/SpiderLabs/ModSecurity/jobs/497221130#L98

Anyway, I think the patch works, wait @zimmerle's notices :)

@victorhora
Copy link
Contributor

Hi @airween I've triggered a rebuild on Travis. Hopefully it will be good until we discuss how we should fix this one :)

In a related matter, I'm also curious why Travis is failing somewhat frequently. :/

@victorhora victorhora added bug It is a confirmed bug 3.x Related to ModSecurity version 3.x pr available labels Feb 25, 2019
@victorhora victorhora added this to the v3.0.4 milestone Feb 25, 2019
@zimmerle
Copy link
Contributor

This subject was under discussion on our Slack channel. @airween have addressed some of the comments and opened a new issue: #2032.

I am closing this in favor of #2031.

@zimmerle zimmerle closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Related to ModSecurity version 3.x bug It is a confirmed bug pr available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants