Skip to content

upgrade web-streams-polyfill #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pgoldberg
Copy link
Contributor

@pgoldberg pgoldberg commented Aug 30, 2022

This is stacked on top of #151 (filter down to the last 3 commits).

This upgrade brings our ponyfilled ReadableStream closer to the whatwg spec, and that actually makes the typings a bit more similar to the native ReadableStream (we don't need to cast as unknown anymore).

This PR also turns on skipLibCheck in our tsconfig, since there seems to be a small type issue in web-streams-polyfill

@pgoldberg pgoldberg force-pushed the pgoldberg/upgradeWebStreamsPolyfill branch from e9eff19 to 699b8b0 Compare August 30, 2022 18:38
@pgoldberg pgoldberg marked this pull request as ready for review August 30, 2022 18:46
Copy link
Contributor

@gluxon gluxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pgoldberg pgoldberg force-pushed the pgoldberg/upgradeWebStreamsPolyfill branch from 699b8b0 to 3b6cb10 Compare September 1, 2022 21:45
@pgoldberg pgoldberg force-pushed the pgoldberg/upgradeWebStreamsPolyfill branch from fdcd51f to 9faefb1 Compare September 1, 2022 21:55
@pgoldberg pgoldberg merged commit 5aaa9c3 into palantir:develop Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants