Skip to content

ENH: Improve typing for Period #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 23, 2022
Merged

Conversation

bashtage
Copy link
Contributor

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Oct 19, 2022

@bashtage For this and the other new PRs you created, can you click the "request review" item in the PR when you are ready for me to do the review?

@bashtage bashtage requested a review from Dr-Irv October 19, 2022 13:23
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you may have responded to some of these comments in the original PR, but better to restart the conversation here.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with everything here, but would like to change __eq__() and __ne__() as described in my comments.

@bashtage
Copy link
Contributor Author

I think it is ready. I also added Series[Period] and PeriodSeries for comparisons.

@bashtage bashtage requested a review from Dr-Irv October 23, 2022 06:53
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage . I think the Literal[False] idea for __eq__() looks good

@Dr-Irv Dr-Irv merged commit 69710a1 into pandas-dev:main Oct 23, 2022
@bashtage bashtage deleted the scalars-period branch November 8, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants