-
-
Notifications
You must be signed in to change notification settings - Fork 143
ENH: Improve typing for Period #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f195f2
to
8ea5cf3
Compare
@bashtage For this and the other new PRs you created, can you click the "request review" item in the PR when you are ready for me to do the review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you may have responded to some of these comments in the original PR, but better to restart the conversation here.
969d26d
to
643b1cb
Compare
a6674ed
to
eafe8ac
Compare
6ca02f0
to
52eab76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with everything here, but would like to change __eq__()
and __ne__()
as described in my comments.
I think it is ready. I also added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bashtage . I think the Literal[False]
idea for __eq__()
looks good
assert_type()
to assert the type of any return valuexref ENH: Improve Pandas scalars #383