Skip to content

Support time start/end for BusinessHour & CustomBusinessHour #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

Support time start/end for BusinessHour & CustomBusinessHour #428

merged 1 commit into from
Nov 17, 2022

Conversation

gandhis1
Copy link
Contributor

Dr-Irv
Dr-Irv approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gandhis1 . Since the docs don't reflect that time is a valid argument, can you create an issue in the pandas repo that says that the docs should be updated?

@Dr-Irv Dr-Irv merged commit c4397e5 into pandas-dev:main Nov 17, 2022
@gandhis1 gandhis1 deleted the time branch November 18, 2022 01:36
@gandhis1
Copy link
Contributor Author

Created PR here: pandas-dev/pandas#49774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CustomBusinessHour accepts a time as start and end
2 participants
@gandhis1 @Dr-Irv