Allow sorted() to work on Index #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Either @twoertwein or @bashtage can review/approve/merge. Approvals from both not needed. Thanks! |
twoertwein
reviewed
Jan 8, 2023
| @@ -92,7 +96,11 @@ def test_column_contains() -> None: | |||
| def test_column_sequence() -> None: | |||
| df = pd.DataFrame([1, 2, 3]) | |||
| col_list = list(df.columns) | |||
| check(assert_type(col_list, List[Union[Scalar, Tuple[Hashable, ...]]]), list, int) | |||
| check( | |||
| assert_type(col_list, List[Union["IndexIterScalar", Tuple[Hashable, ...]]]), | |||
There was a problem hiding this comment.
Other tests (test_series.py) import from __future__ import annotations to use tuple/list.
There was a problem hiding this comment.
It won't work at runtime on python 3.8. CI failed for me when I did that. You can do foo: list[int] and that will be accepted, but if you are doing assert_type(col_list, list[Union["IndexIterScalar", tuple[Hashable, ...]]]) that will fail at runtime on 3.8 because the runtime for 3.8 can't parse something like list[int] when it is not a typing annotation.
twoertwein
approved these changes
Jan 8, 2023
|
Thanks @Dr-Irv ! |
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
* trying SupportsRichComparisonT * create IndexIterScalar type for sorted(Index) to work * Use List not list, and Tuple not tuple for 3.8 compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_indexes.py:test_sorted_and_list()