Skip to content

gh:284 - resolving various axis types #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2023
Merged

gh:284 - resolving various axis types #561

merged 2 commits into from
Mar 2, 2023

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Mar 2, 2023 •
edited
Loading

Sir you can check and if any changes are required i'll do it

Dr-Irv
Dr-Irv requested changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix in core/generic.pyi sort_index() to use Axis for the axis argument?

Can you fix in core/series.pyi 'compare()to use the appropriate type foralign_axis` argument?

Otherwise, this looks good beyond the other comments I made.

Dr-Irv
Dr-Irv approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ramvikrams

@ramvikrams
Copy link
Contributor Author

thanks @ramvikrams

thanks a lot sir

@Dr-Irv Dr-Irv merged commit 24288ee into pandas-dev:main Mar 2, 2023
@ramvikrams ramvikrams deleted the t01 branch March 3, 2023 09:08
twoertwein pushed a commit to twoertwein/pandas-stubs that referenced this pull request Apr 1, 2023
@ramvikrams @twoertwein
gh:284 - resolving various axis types (pandas-dev#561)
7c42ae2 
* resolving various axis types

* Removed commented lines and required changes done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLEAN: Resolve Axis and AxisType
2 participants
@ramvikrams @Dr-Irv