-
-
Notifications
You must be signed in to change notification settings - Fork 143
Replace flake8 and pyupgrade with ruff #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @twoertwein
@twoertwein So I thanked you for this, then forgot to merge, and now there is a conflict. Can you resolve that conflict and push again? |
…y special methods without return types
This reverts commit b3673c3.
Sorry, did |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @twoertwein
Pandas switched to ruff a while ago: ruff is much faster and combines many different tools (including flake8-pyi and pyupgrade).
ruff fails currently because of this line which looks a bit weird:
pandas-stubs/pandas-stubs/io/formats/style.pyi
Line 43 in 89e083b